Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user ID check from createIntegration #305

Conversation

brendanrmoore
Copy link

@brendanrmoore brendanrmoore commented Apr 18, 2024

The Slack API module uses a many to 1 mapping of integrations to Slack entities when those integrations all connect to the same Slack workspace. However, this conflicts with the user ID check here which will throw an error if the user IDs don't match.

Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@brendanrmoore brendanrmoore changed the title remove user ID check Remove user ID check from createIntegration Apr 18, 2024
@brendanrmoore brendanrmoore marked this pull request as ready for review April 18, 2024 20:11
Copy link
Contributor

@MichaelRyanWebber MichaelRyanWebber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This has been running (without this check) in v1 with no problem.

@MichaelRyanWebber MichaelRyanWebber merged commit 1b8a1ea into friggframework:version-0 Apr 18, 2024
4 of 5 checks passed
@seanspeaks
Copy link
Contributor

🚀 PR was released in @friggframework/integrations@1.2.5, @friggframework/types@0.2.5 🚀

@seanspeaks seanspeaks added the released This issue/pull request has been released. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants